Adding tests for versioning updates through relation changes that should pass (but don't) #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uld pass (but don't)
24 tasks
Co-Authored-By: ScopeyNZ <[email protected]>
ScopeyNZ
commented
Dec 2, 2018
| $this->assertCount( | ||
| 4, | ||
| Versioned::get_all_versions(ParentObject::class, $parent->ID), | ||
| 'Adding an relation to an object that owns that relation that is a relation owned by the parent object did ' |
There was a problem hiding this comment.
This was hard to describe in a message 😂
|
@unclecheese Are you likely to need this with the work you've been doing? If not feel free to close it 🙂 |
|
Closing as this is covered by the unit test suite in versioned-snapshots. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just adds a failing test for the issue described in #195 . This shouldn't be merged without a fix to correct the failing test but it's here for the record